box_overlaps.pyx line46, ih equation issue

tsinghua-rll / VoxelNet-tensorflow

A 3D object detection system for autonomous driving.

MIT License

454 stars 123 forks source link

box_overlaps.pyx line46, ih equation issue #59

Open wayneguo166 opened 5 years ago

wayneguo166 commented 5 years ago

Hello Jeasinema, I go through the codes these days and find a issue during calculate the ih in bbox_overlaps function, your code are: ih = ( min(boxes[n, 3], query_boxes[k, 3]) - max(boxes[n, 1], query_boxes[k, 1]) + 1 ) but I think it should be: ih = ( min(boxes[n, 1], query_boxes[k, 1]) - max(boxes[n, 3], query_boxes[k, 3]) + 1 ) wish your feedback, thanks. quick link: https://github.com/tsinghua-rll/VoxelNet-tensorflow/blob/d24c3eefc5762e4785ca3be6ca7d1fd0ef16bc61/utils/box_overlaps.pyx#L46

andrearama commented 5 years ago

Hi, although I am not sure either which one is right, I found another issue regarding this implementation #35

honghuixuhenry commented 4 years ago

How to slove this problem "ModuleNotFoundError: No module named 'utils.box_overlaps'"