tsitu / MH-Tools

Assortment of MouseHunt utilities
https://tsitu.github.io/MH-Tools/
Apache License 2.0
30 stars 35 forks source link

Update CRE special effect logic #237

Closed Neb-RS closed 1 year ago

Neb-RS commented 1 year ago

Started as a Rook Crumble Charm with side-specific trap interaction issues as reported in the Discord: https://discord.com/channels/275500976662773761/1044702955993055352/1072929184021762048. I intended to duplicate the trap logic to then also add the rook into it, but this was way too messy.

I ended up reworking how it works to make it work much easier and cleaner. Now it basically checks for all effects, adds those, and does the calculation at the end. Also future-proofs it I guess, just in case there's some weird instance later where this does matter: some draconic mouse in Zugzwang or something.

It seemed to work well locally. But definitely test it first, please. Thanks to ChatGPT for the dummy code so I could actually make the idea work :D