search

tsitu / MH-Tools

Assortment of MouseHunt utilities
https://tsitu.github.io/MH-Tools/
Apache License 2.0
30 stars 35 forks source link

fix: puppeteer grabbing timestamps #256

Closed hymccord closed 1 year ago

hymccord commented 1 year ago

GitHub may have updated their DOM at some point but the current selector will not get the latest modified time.

I originally updated the selectors and ran puppeteer locally and it worked but never seemed to work when running on github actions.

Migrated to using the GitHub REST API which removes the need for hardcoding the order of the bookmarks.

If npm run timestamp is run from the CI pipeline, it will get a token with a higher limit (will still be anon here b/c it won't use the updated workflow until merged).

hymccord commented 1 year ago

~~Back to draft. Seems like puppeteer doesn't like to work in the runner like it does when I run locally. Will look into using GitHub API.~~

Updated.