Closed jeromekelleher closed 2 years ago
Looks great!
L Great TM. A few comments:
tskit
things, should we mention metadata and individuals (i.e. the individuals table), as these are fairly major improvements to usability, I think?one observation here-- a lot of this information is hierarchically nested. would a figure a better choice? e.g.
one observation here-- a lot of this information is hierarchically nested. would a figure a better choice? e.g.
Not sure I agree here: the interface is one "thing"; ancestry and mutation simulations (etc) are independent of that? I agree the line for demography and interface is very hazy though.
"More efficient for large numbers of populations" - maybe give values and/or a comparator - e.g. 20x more efficient than msprime 0.3 for large populations?
That's a bit of a how-long-is-a-piece-of-string one @Yan - pre 1.0 performance was quadratic in the number of populations. Now it's much better. There's no one number, though and you'd need to say something like "for example, in a 1D stepping stone model with 100 populations, and one haploid sample drawn each from the ends of the habitat and no recombination, we are X times faster"
"More efficient for large numbers of populations" - maybe give values and/or a comparator - e.g. 20x more efficient than msprime 0.3 for large populations?
That's a bit of a how-long-is-a-piece-of-string one @yan - pre 1.0 performance was quadratic in the number of populations. Now it's much better. There's no one number, though and you'd need to say something like "for example, in a 1D stepping stone model with 100 populations, and one haploid sample drawn each from the ends of the habitat and no recombination, we are X times faster"
Right, don't worry if it's not easy to say: it just sounded a little hand-wavy, but perhaps there's no better way to put it succinctly.
Perhaps "improved scaling (no longer quadratic) in the number of populations"? Or is that worse?
Do we want to mention the ability to do multiple chromosomes using DTWF and the hack at https://tskit.dev/msprime/docs/latest/ancestry.html#multiple-chromosomes or is that too much of a hack at the moment?
Too hacky I think, not worth bringing up.
Thanks for the input @hyanwong, this is very helpful. How does this look now?
Is it also worth mentioning that the interface now supports widespread use of population names as an alternative to using numerical ids?
Good point @grahamgower . How about
Improved interface with integrated metadata and referencing populations by name. Import from...
Yep, sounds good.
Updated
Thanks for the input @hyanwong, this is very helpful. How does this look now?
Great! Nice work @jeromekelleher
OK, let's merge this then. Thanks for the input!
One of the main things we need is some summary of the major updates to msprime. Here's a first pass:
What do we think?