search

tskit-dev / msprime

Simulate genealogical trees and genomic sequence data using population genetic models
GNU General Public License v3.0
170 stars 84 forks source link

remove tests/data folder #2228

Closed GertjanBisschop closed 6 months ago

GertjanBisschop commented 6 months ago

remove tests/data folder as mentioned in #1952 .

GertjanBisschop commented 6 months ago

Aha, the contents of this folder are still used in the following places. Have misunderstood the issue. 

test_demography.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/minimal-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/minimal-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/single-locus-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/single-locus-example.trees")
test_species_tree_parsing.py:        tree_file = "tests/data/species_trees/101g_nucl_conc_unconst.combined.nwk.tre"
test_species_tree_parsing.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:
test_species_tree_parsing.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:

So is it only tests/data/hdf5-formats and tests/data/simplify-bugs that should be removed?

jeromekelleher commented 6 months ago

Ah yes, good spot. Let's remove just unused stuff

codecov[bot] commented 6 months ago

Codecov Report

Merging #2228 (9c1e5b6) into main (13bf955) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228/graphs/tree.svg?width=650&height=150&src=pr&token=1uZQV1KMkU&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev)](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) ```diff @@ Coverage Diff @@ ## main #2228 +/- ## ======================================= Coverage 91.52% 91.52% ======================================= Files 20 20 Lines 11334 11334 Branches 2302 2302 ======================================= Hits 10373 10373 Misses 523 523 Partials 438 438 ``` | [Flag](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | Coverage Δ | | |---|---|---| | [C](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `91.52% <ø> (ø)` | | | [python](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `98.70% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev). Last update [13bf955...9c1e5b6](https://app.codecov.io/gh/tskit-dev/msprime/pull/2228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev).