tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
27 stars 23 forks source link

edited tutorial.md to take a sample of individuals #182

Closed chriscrsmith closed 3 years ago

chriscrsmith commented 3 years ago

Referencing issue #175, I offered some edits to the tutorial for (1) taking a sample from a population, (2) taking a sample after simplification.

codecov-commenter commented 3 years ago

Codecov Report

Merging #182 (01aefc8) into main (babfedf) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files           7        7           
  Lines         987      987           
  Branches      188      188           
=======================================
  Hits          867      867           
  Misses         88       88           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update babfedf...01aefc8. Read the comment docs.

petrelharp commented 3 years ago

Looks good, thanks! A couple of questions.

Also, FYI - it's more usual to do a PR from a separate branch; that will make it so you won't have to force-push to main on your fork later.

chriscrsmith commented 3 years ago

Thanks for looking over this.

I'll revise- in another branch- and do a new PR. Sound good?