search

tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
27 stars 23 forks source link

population_size method #189

Closed petrelharp closed 3 years ago

petrelharp commented 3 years ago

Closes #186.

codecov-commenter commented 3 years ago

Codecov Report

Merging #189 (edd5a04) into main (a1d5588) will increase coverage by 0.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   87.84%   88.40%   +0.56%     
==========================================
  Files           7        8       +1     
  Lines         987     1035      +48     
  Branches      188      198      +10     
==========================================
+ Hits          867      915      +48     
  Misses         88       88              
  Partials       32       32
Impacted Files Coverage Δ
pyslim/__init__.py 100.00% <100.00%> (ø)
pyslim/spatial.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1d5588...edd5a04. Read the comment docs.

petrelharp commented 3 years ago

Todo (note to ourselves, I just remembered the second thing):

petrelharp commented 3 years ago

Looks good! I just want to write one more test, with a known answer.

Also: do you know how fast this is for a big-ish tree sequence with a fine spatial grid (e.g., 100x100)?

petrelharp commented 3 years ago

Ok, I've added a simple test to catch the edge cases; it works! Have a look at my changes; see what you think.

petrelharp commented 3 years ago

Approved by @giliapatterson - merging!!