search

tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
27 stars 23 forks source link

added slim clone and compile to GH actions #291

Closed andrewkern closed 2 years ago

andrewkern commented 2 years ago

set up GH actions to build SLiM and test pyslim on windows

petrelharp commented 2 years ago

Sorry, yet another question - I see that ci-environment.yml is used only for Windows, while various requirements.txt serve for the other platforms. Is there a good reason for this, or can I just make them all use the same file?

andrewkern commented 2 years ago

right. so i'm doing things a bit different in the Windows section than what you had originally. I'm using conda with a yaml environment file on instantiation that builds the virtual environment with everything preinstalled. the way you had been doing it was to create a conda environment, and then in separate steps install the conda reqs and then the pip reqs. Using a single conda env file on instantiations collapses all these steps down to one step and saves a bunch of time on the GH action workflow.

I didn't edit the macos / ubuntu side of things as it currently just works. IMO the right thing to do next would be to edit those sections of the workflow to do similar, and then to ditch conda and move to a provisioned micromamba setup. I'd vote we do that on a separate PR, once this is merged as an example.

andrewkern commented 2 years ago

closing this cause i've got a cleaner PR on deck