search

tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
26 stars 23 forks source link

refactor of GH test action workflow #294

Closed andrewkern closed 1 year ago

andrewkern commented 1 year ago

Okay this is a brand new, spiffy workflow that allows for a few things:

  1. SLiM is now built in windows environments and pyslim tests run on that executable
  2. micromamba replaces miniconda as the package manager. this leads to considerable speed ups.
  3. caching now works properly across all systems. to make this work without ugly hacks, i've had to pin the GH actions/cache to version 3.0.5. this is noted in the code and the GH issue covering the issue (i.e. new version breaks everything on windows) is cited.

@petrelharp this is now done!

andrewkern commented 1 year ago

this closes #232

andrewkern commented 1 year ago

so we could put similar, cleaned up workflows in tskit or SLiM... not sure if folks would want that?

bhaller commented 1 year ago

so we could put similar, cleaned up workflows in tskit or SLiM... not sure if folks would want that?

@andrewkern I don't really grok this GitHub Actions stuff; @grahamgower set up SLiM's for me a while back, and then others such as @rdinnager have added to it with support for Windows etc. over time. So maybe they have an opinion about this? I guess for SLiM's purposes the main thing we're talking about is using micromamba? You also mention caching; I'm not sure whether that is presently working properly for SLiM on all platforms or not. Anyhow, I'm happy to accept a helpful PR, but I don't understand this stuff well enough to really have an opinion, and as far as I can tell SLiM's CI has been working well lately. Now is a good time to break/fix the CI, since SLiM 4 is now out the door. :-> Thanks for the offer!