Closed silastittes closed 1 year ago
This is great, Silas. I was hoping you might stick in the comparison of site-diversity to branch-length-diversity here as well somehow, with some explanation? (before the 'recapitation' bit) That would make things more concrete?
(Also see the errors in building the docs.)
DOH! But thanks! And I agree adding the diversity comparisons makes sense, will make the needed updates soon!
I updated the cache value and added some site-diversity to branch-length-diversity details. Hopefully all looks good and build docs works! But happy to revise of course!
Weird I have to keep clicking "approve" on your checks - I will look into this later.
Merging #301 (5308e34) into main (c857776) will decrease coverage by
0.15%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 95.59% 95.43% -0.16%
==========================================
Files 8 6 -2
Lines 613 592 -21
Branches 127 127
==========================================
- Hits 586 565 -21
Misses 18 18
Partials 9 9
Impacted Files | Coverage Δ | |
---|---|---|
pyslim/__init__.py | ||
pyslim/util.py |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Great! I put in a bit more explanation (e.g., something about why that check works), and removed the need to re-simulate without mutations - what do you think?
Awesome! Looks great and helped to clarify several ideas I was unsure about.
Edits to use the new
meanParentAge
property introduced in SLiM 4.0.1, with minor edits in body of text to explain the update.