tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
26 stars 23 forks source link

updates to demo use of meanParentAge #301

Closed silastittes closed 1 year ago

silastittes commented 1 year ago

Edits to use the new meanParentAge property introduced in SLiM 4.0.1, with minor edits in body of text to explain the update.

petrelharp commented 1 year ago

This is great, Silas. I was hoping you might stick in the comparison of site-diversity to branch-length-diversity here as well somehow, with some explanation? (before the 'recapitation' bit) That would make things more concrete?

petrelharp commented 1 year ago

(Also see the errors in building the docs.)

silastittes commented 1 year ago

DOH! But thanks! And I agree adding the diversity comparisons makes sense, will make the needed updates soon!

silastittes commented 1 year ago

I updated the cache value and added some site-diversity to branch-length-diversity details. Hopefully all looks good and build docs works! But happy to revise of course!

petrelharp commented 1 year ago

Weird I have to keep clicking "approve" on your checks - I will look into this later.

codecov-commenter commented 1 year ago

Codecov Report

Merging #301 (5308e34) into main (c857776) will decrease coverage by 0.15%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   95.59%   95.43%   -0.16%     
==========================================
  Files           8        6       -2     
  Lines         613      592      -21     
  Branches      127      127              
==========================================
- Hits          586      565      -21     
  Misses         18       18              
  Partials        9        9              
Impacted Files Coverage Δ
pyslim/__init__.py
pyslim/util.py

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

petrelharp commented 1 year ago

Great! I put in a bit more explanation (e.g., something about why that check works), and removed the need to re-simulate without mutations - what do you think?

silastittes commented 1 year ago

Awesome! Looks great and helped to clarify several ideas I was unsure about.