search

tskit-dev / pyslim

Tools for dealing with tree sequences coming to and from SLiM.
MIT License
26 stars 23 forks source link

Suggestion for vignette: a spatial simulation #332

Closed jiseonmin closed 8 months ago

jiseonmin commented 9 months ago

Hey, thank you for a helpful vignette on spatial simulations! I saw that the third entry of the location list is included when calculating the geographic distance. May I suggest using only the first two entries, since the example is in a two dimensional space?

petrelharp commented 8 months ago

OMG good catch. (And I somehow just noticed these PRs.)

codecov-commenter commented 8 months ago

Codecov Report

Merging #332 (1e9d905) into main (76ed446) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           8        8           
  Lines         621      621           
  Branches      131      131           
=======================================
  Hits          594      594           
  Misses         18       18           
  Partials        9        9

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!