search

tskit-dev / tsdate

Infer the age of ancestral nodes in a tree sequence.
MIT License
19 stars 10 forks source link

sample_as_parent in variational_gamma #394

Open hyanwong opened 3 months ago

hyanwong commented 3 months ago

One of the tests for the inside_outside method is test_sample_as_parent_fails. Can we actually date samples that have descendant undated nodes using the current variational_gamma implementation, or should we be failing in this case too, @nspope ?

nspope commented 3 months ago

The machinery is (mostly) there but it's not working yet. Do we need to add an exception so that it errors out appropriately?

hyanwong commented 3 months ago

Right, I guess it would be helpful to error out, but it's not a high priority. Does the same go for non-contemporary samples?

nspope commented 3 months ago

Yup, same deal -- EP machinery in place, but rescaling routine doesn't do the right thing yet (although it's conceptually very straightforward to incorporate). Not going to worry about getting all that sorted out until we have a solid application.