search

tskit-dev / tskit-site

tskit website
Other
0 stars 8 forks source link

Confusing behaviour of navbar links #151

Closed hyanwong closed 1 year ago

hyanwong commented 1 year ago

A really minor thing, but it keeps bugging me. If I click on e.g. python-api.html#treesequence-api, the right hand navbar doesn't expand the "TreeSequence API" section to show the various subcategories within that section. Instead, I have to scroll down a fraction to get the navbar to show the subcategories in that section.

This means that e.g. clicking on the link in the navbar doesn't expand the section, as you might hope. In fact, when you click on one of those navbar links, the previous topic is expanded, which is really confusing.

E.g. here's the result I get when clicking on "Tables and Table Collections" in the navbar (it looks like Tree API->Export is highlighted, because that's the subsubsection before the "Tables and Table Collections" heading).

Screenshot 2022-11-17 at 18 32 25
benjeffery commented 1 year ago

I think this might get fixed if I pull in the upstream changes from sphinx-book-theme.

hyanwong commented 1 year ago

Oh, that would be good, thanks. It's a minor thing, but bugs me a lot!

hyanwong commented 1 year ago

I think this might get fixed if I pull in the upstream changes from sphinx-book-theme.

Did you manage to see if this fixed the problem @benjeffery ?

daikitag commented 1 year ago

It seems that it is a bug from the previous version of sphinx-book-theme, and they have fixed it in their new release. https://github.com/executablebooks/sphinx-book-theme/pull/677 It might be possible to fix the issue after incorporating the recent release of sphink-book-theme

benjeffery commented 1 year ago

Ah good, have they re-organised their CSS though? Might be easier just to port across the fix.

daikitag commented 1 year ago

It seems that they had fixed their CSS as well, but 100+ files were changed compared with the version that you used to build tskit-book-theme. Do you think you can successfully merge their current version to tskit-book-theme? I can try changing it, but I think it would be difficult for me, as I'm not sure about which files you had modified from sphix-book-theme.

benjeffery commented 1 year ago

This still seems to happen, when using the latest docs that use sphinx-book-theme directly. I'll keep updating as they release, and it might get fixed, but I'm closing here as there is nothing we can do.