tskit-dev / tskit-site

tskit website
Other
0 stars 8 forks source link

tstrait-news #191

Closed daikitag closed 11 months ago

daikitag commented 1 year ago

@hyanwong Does this look good? Thank you very much for writing the news article, and I'm very excited about it!

hyanwong commented 1 year ago

Hi @daikitag - your photo seems to be 6.2MB! Maybe a smaller version would be good? Wilder's picture is 12kb (238 × 238px).

daikitag commented 1 year ago

@hyanwong Does this look good?

hyanwong commented 1 year ago

Seems GTM. Lets see what @benjeffery thinks.

hyanwong commented 1 year ago

Oh, and (sorry!) a last thing: do you want to add the plot itself to the page. See e.g. https://tskit.dev/news/20221025-tsinfer-0.3.0.html which has a few embedded plot outputs.

daikitag commented 11 months ago

I think it would be great to add a plot to the news page. Do you think it is possible to add the histogram that is produced in the example code to the website?

daikitag commented 11 months ago

@hyanwong I think there is a warning message showing up in the html theme of conf.py file. Would it be possible for you to check it, as it is unrelated to the tstrait news update?

hyanwong commented 11 months ago

I think it would be great to add a plot to the news page. Do you think it is possible to add the histogram that is produced in the example code to the website?

I think you can just save it to PNG and put it in the same folder as your photo?

benjeffery commented 11 months ago

Let me know when you're done here @daikitag - there are some issues with doc builds that I'm fixing that need to go in.

daikitag commented 11 months ago

@benjeffery I think it is done now. Would it be possible for you to update the changes? Thank you for your help.

benjeffery commented 11 months ago

Rebased - @daikitag Don't push to this PR without git fetch origin && git reset --hard origin/tstrait-news assuming your fork is the origin.

hyanwong commented 11 months ago

I'm not sure the link in the description: | field plays nicely: but otherwise LGTM. @benjeffery - do you want to remove the link ([tstrait](https://tskit.dev/software/tstrait.html) -> tstrait) and merge?

benjeffery commented 11 months ago

Removed from description and moved to text. Documentation link fixed.