tskit-dev / tskit

Population-scale genomics
MIT License
147 stars 69 forks source link

Fix codecov paths #2930

Closed benjeffery closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.68%. Comparing base (c9746af) to head (394e32a).

:exclamation: Current head 394e32a differs from pull request most recent head eef479f. Consider uploading reports for the commit eef479f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2930 +/- ## ========================================== + Coverage 85.72% 89.68% +3.96% ========================================== Files 10 29 +19 Lines 15792 30385 +14593 Branches 3062 5897 +2835 ========================================== + Hits 13537 27250 +13713 - Misses 1261 1793 +532 - Partials 994 1342 +348 ``` | [Flag](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | Coverage Δ | | |---|---|---| | [c-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `86.20% <ø> (-0.01%)` | :arrow_down: | | [lwt-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `80.78% <ø> (ø)` | | | [python-c-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `88.72% <ø> (?)` | | | [python-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `98.96% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 20 files with indirect coverage changes](https://app.codecov.io/gh/tskit-dev/tskit/pull/2930/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev)
benjeffery commented 2 months ago

I finally understand why we've been getting so much odd codecov behaviour, I think! Some reports were not being used as the paths were relative to a subdirectory. Hopefully this fixes that.