search

tskit-dev / tskit

Population-scale genomics
MIT License
147 stars 69 forks source link

Drop metadata schemas on tables. #2945

Closed jeromekelleher closed 2 months ago

jeromekelleher commented 2 months ago

Closes #2944

Mostly done, just needs a quick test on drop_schemas

Some incidental Black-update noise also

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.63%. Comparing base (d32d63f) to head (a31ee1c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2945 +/- ## ======================================= Coverage 89.63% 89.63% ======================================= Files 29 29 Lines 30174 30184 +10 Branches 5873 5875 +2 ======================================= + Hits 27046 27056 +10 Misses 1789 1789 Partials 1339 1339 ``` | [Flag](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | Coverage Δ | | |---|---|---| | [c-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `86.20% <ø> (ø)` | | | [lwt-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `80.78% <ø> (ø)` | | | [python-c-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `88.72% <ø> (ø)` | | | [python-tests](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | `99.03% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev) | Coverage Δ | | |---|---|---| | [python/tskit/metadata.py](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945?src=pr&el=tree&filepath=python%2Ftskit%2Fmetadata.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev#diff-cHl0aG9uL3Rza2l0L21ldGFkYXRhLnB5) | `99.04% <100.00%> (+<0.01%)` | :arrow_up: | | [python/tskit/tables.py](https://app.codecov.io/gh/tskit-dev/tskit/pull/2945?src=pr&el=tree&filepath=python%2Ftskit%2Ftables.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tskit-dev#diff-cHl0aG9uL3Rza2l0L3RhYmxlcy5weQ==) | `98.96% <100.00%> (+<0.01%)` | :arrow_up: |
benjeffery commented 2 months ago

Merging and rebasing on #2946 will fix the noise.