search

tskit-dev / tszip

Gzip-like compression for tskit tree sequences
https://tszip.readthedocs.io/
MIT License
4 stars 6 forks source link

Use dict representation for compress and decompress #42

Closed benjeffery closed 3 years ago

benjeffery commented 3 years ago

Fixes #39 Fixes #38

codecov-commenter commented 3 years ago

Codecov Report

Merging #42 (dc770d3) into main (55e7fb4) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   97.57%   97.70%   +0.12%     
==========================================
  Files           6        6              
  Lines         289      305      +16     
  Branches       42       55      +13     
==========================================
+ Hits          282      298      +16     
  Misses          5        5              
  Partials        2        2
Impacted Files Coverage Δ
tszip/compression.py 98.88% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55e7fb4...dc770d3. Read the comment docs.

jeromekelleher commented 3 years ago

We should update the CHANGELOG with a summary of the changes. So the idea is that the tszip encoding should be identical to older versions?

Is there any way we can verify this? Maybe we should put in a few old tszipped files in repo, and verify that we recover these correctly, at least?

benjeffery commented 3 years ago

I've added a changelog and a test of a legacy file. The idea is that old files should still work.