tskit-dev / what-is-an-arg-paper

Manuscript and code for the "What is an ARG?" paper
1 stars 8 forks source link

Tsinfer figure is without "root breaking" #390

Closed hyanwong closed 10 months ago

hyanwong commented 11 months ago

I just realised that the tsinfer figure shows the "old" tsinfer behaviour, in which the ultimate ancestor is not broken into pieces. Breaking the root up like this is now the default. So should we show it? The plot would then look something like this:

Screenshot 2023-10-16 at 13 42 35

To compare, this is what it looks like at the moment:

Screenshot 2023-10-16 at 13 46 06
hyanwong commented 11 months ago

The colour scheme doesn't quite highlight the local roots in KwARG (A) and ARGweaver (B), because local roots are inferred to have ancestors that connect them to the grand MRCA.

jeromekelleher commented 11 months ago

Let's go with recent version, after discussion

hyanwong commented 10 months ago

Fixed in #398