search

tsl0922 / ImPlay

A Cross-Platform Desktop Media Player
https://tsl0922.github.io/ImPlay
GNU General Public License v2.0
599 stars 46 forks source link

Full screen windows minimizes when mouse click on another monitor #52

Closed TauZolver closed 11 months ago

TauZolver commented 1 year ago

Is your feature request related to a problem? Please describe. In a multi-monitor setup (OS: Windows 10 21H2), ImPlay's windowed full screen minimizes when mouse is clicked on another monitor. This behavior is a bit inconvenient and different from MPV's.

Describe the solution you'd like According to https://github.com/glfw/glfw/issues/447, fullscreen can remain maximized when it loses focus by setting the Window Attribute glfwWindowHint(GLFW_AUTO_ICONIFY, GL_FALSE) The attribute conflicts with the ontop function at windowed mode, so it should only be enabled for fullscreen.

Describe alternatives you've considered I attempted implementing a fix https://github.com/TauZolver/ImPlay/commit/a970575da09ab03e59b0bafc592b82fa5a5f5e15 that works for my Windows PC, but I do not have machines to test if works for MacOS and Linux platforms.

Additional context Thanks for the amazing work! ImPlay gives motivation for one to want to drop PotPlayer for good.

tsl0922 commented 11 months ago

GLFW_AUTO_ICONIFY is GL_FALSE now.