search

tsl0922 / ttyd

Share your terminal over the web
https://tsl0922.github.io/ttyd
MIT License
7.97k stars 875 forks source link

1.7.6 reports incorrect version #1339

Closed maciejwalkowiak closed 5 months ago

maciejwalkowiak commented 5 months ago

Describe the bug

ttyd -v reports version 0.0.0-unknown making it impossible to use with https://github.com/charmbracelet/vhs, as VHS checks the ttyd version number before it runs.

To Reproduce

$ brew install ttyd
$ ttyd -v
ttyd version 0.0.0-unknown

Environment:

tsl0922 commented 5 months ago

It should work if you install it with brew install ttyd --HEAD.

The version info is fetched from git tag in 1.7.6 release, homebrew uses source archive which is not a git repo, so no version info will be detected..

maciejwalkowiak commented 5 months ago

Thanks for quick reply. Confirming, installing with --HEAD solves the problem.

tsl0922 commented 5 months ago

Sorry for the confusion, I've released 1.7.7 to revert the static version in source archive.

The release action now checks the version bump, it will fail if I forget to bump version in CMakeLists.txt.

maciejwalkowiak commented 5 months ago

Fantastic! Thank you!