tslearn-team / tslearn

The machine learning toolkit for time series analysis in Python
https://tslearn.readthedocs.io
BSD 2-Clause "Simplified" License
2.92k stars 342 forks source link

List of improvements expected for tslearn version 0.6.2 #460

Open YannCabanes opened 1 year ago

YannCabanes commented 1 year ago

For the version 0.6.2 of tslearn, the following improvements are expected:

codecov-commenter commented 1 year ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.06%. Comparing base (f718dd5) to head (d375389). Report is 31 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #460 +/- ## ======================================= Coverage 93.06% 93.06% ======================================= Files 67 67 Lines 5625 5625 ======================================= Hits 5235 5235 Misses 390 390 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rtavenar commented 1 year ago

If I may add something: at the moment, the tests install scikit-learn v1.0, which does not provide wheels for Python 3.10. As a result, for all tests running on Python 3.10, a large part of the test time is dedicated to compiling scikit-learn. It would be a good idea, if feasible, to switch to scikit-learn 1.3 for the tests.

YannCabanes commented 1 year ago

The documentation of the class SoftDTWLossPyTorch has been improved in the PR #467.

rtavenar commented 1 year ago

If I may add something: at the moment, the tests install scikit-learn v1.0, which does not provide wheels for Python 3.10. As a result, for all tests running on Python 3.10, a large part of the test time is dedicated to compiling scikit-learn. It would be a good idea, if feasible, to switch to scikit-learn 1.3 for the tests.

We are not there (=1.3) yet, however we upgraded tests to support scikit-learn 1.2, which provides wheels for Python 3.8 to 3.11 it seems