Open YannCabanes opened 1 year ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.06%. Comparing base (
f718dd5
) to head (d375389
). Report is 31 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If I may add something: at the moment, the tests install scikit-learn v1.0, which does not provide wheels for Python 3.10. As a result, for all tests running on Python 3.10, a large part of the test time is dedicated to compiling scikit-learn. It would be a good idea, if feasible, to switch to scikit-learn 1.3 for the tests.
The documentation of the class SoftDTWLossPyTorch
has been improved in the PR #467.
If I may add something: at the moment, the tests install scikit-learn v1.0, which does not provide wheels for Python 3.10. As a result, for all tests running on Python 3.10, a large part of the test time is dedicated to compiling scikit-learn. It would be a good idea, if feasible, to switch to scikit-learn 1.3 for the tests.
We are not there (=1.3) yet, however we upgraded tests to support scikit-learn 1.2, which provides wheels for Python 3.8 to 3.11 it seems
For the version 0.6.2 of tslearn, the following improvements are expected:
Segmentation fault
):test_symmetric_cdist
--> The failing rate of this test is about 3/4test_gamma_soft_dtw
--> The failing rate of this test is about 1/5 When these tests are failing, the error messages can be different from one fail to the other: the Segmentation fault can occur in different lines of the code. These two tests are currently skipped with MacOS for Python 3.9.be
? We should test both cases: with backend inferred from data and with backend explicitly specified, even with data from another format. --> This problem has been dealt with in PR #479.PyTorch
backend, do we differentiate at fixed path? --> This problem has been dealt with in PR #482.SoftDTWLossPyTorch
should be improved. --> The documentation of the classSoftDTWLossPyTorch
has been improved in the PR #467.Backend
inbackend/backend.py
, should we overload__getattr__
instead of listing all attributes? --> This requirement has been dealt with in PR #471.