search

tslearn-team / tslearn

The machine learning toolkit for time series analysis in Python
https://tslearn.readthedocs.io
BSD 2-Clause "Simplified" License
2.92k stars 342 forks source link

Improve the docstring of the class SoftDTWLossPyTorch #467

Closed YannCabanes closed 1 year ago

YannCabanes commented 1 year ago

Improve the docstring of the class SoftDTWLossPyTorch and rename the parameter dist_func into squared_dist_func.

YannCabanes commented 1 year ago

Hello @rtavenar, could you review this PR please? The failing tests are not related to this PR, I am trying to solve these issues in the PR #468.

rtavenar commented 1 year ago

This looks great. I only have two comments and we should be able to merge soon.

YannCabanes commented 1 year ago

I think that this PR is now ready to be merged. @rtavenar, could you confirm?

YannCabanes commented 1 year ago

All tests using Python 3.10 have failed.

YannCabanes commented 1 year ago

All tests using Python 3.10 have failed.