search

tslearn-team / tslearn

The machine learning toolkit for time series analysis in Python
https://tslearn.readthedocs.io
BSD 2-Clause "Simplified" License
2.89k stars 336 forks source link

Simplify backend #471

Closed YannCabanes closed 1 year ago

YannCabanes commented 1 year ago

Simplify the way the attributes and methods are defined in the class Backend.

YannCabanes commented 1 year ago

Hello @rtavenar, could you give me your opinion on this PR please?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% :warning:

Comparison is base (a9c5ce3) 92.87% compared to head (fb00b7c) 92.79%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #471 +/- ## ========================================== - Coverage 92.87% 92.79% -0.08% ========================================== Files 67 67 Lines 5643 5583 -60 ========================================== - Hits 5241 5181 -60 Misses 402 402 ``` | [Files Changed](https://app.codecov.io/gh/tslearn-team/tslearn/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tslearn-team) | Coverage Δ | | |---|---|---| | [tslearn/backend/backend.py](https://app.codecov.io/gh/tslearn-team/tslearn/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tslearn-team#diff-dHNsZWFybi9iYWNrZW5kL2JhY2tlbmQucHk=) | `81.81% <100.00%> (-11.74%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

YannCabanes commented 1 year ago

All checks have passed.