search

tslittle / tiffanymaster

0 stars 0 forks source link

Providers excluded when more than 50 exist #9

Open tslittle opened 3 years ago

tslittle commented 3 years ago

https://bugs.launchpad.net/evergreen/+bug/1895551

tslittle commented 3 years ago

The pertinent commit where Galen mentions that it's been bumped to 100 results is here:

https://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=26644f6975e1f845d86c0faf2d1bf47278905c7a

tslittle commented 3 years ago

Some other commits from the Acq Search work to maybe see how this is handled when there's a perm check in use:

https://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9172b708200f2c38e16dfb502b3e9633edb2a703

https://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2d9ba44f750b1090ff487649257d037c4c99848d

tslittle commented 3 years ago

I think I need to look at something like patron search where it has to limit the search? Or what about when you're creating a provider and in the dropdown menu it only shows orgs that you have access to?

tslittle commented 3 years ago

This comes into play into this new bug that I filed too: https://bugs.launchpad.net/evergreen/+bug/1922108

What about adding a perm/OU check before the idl retrieve? So that it's shorter?

tslittle commented 3 years ago

This is fixed in the angular LMOR work I'm doing, because in the service pcrud call I'm already limiting by work_ou. IDK how to fix this in the search work because that doesn't do the same blatant kind of ou check.