tsloughter / erlup

Erlang toolchain installer

14 stars 2 forks source link

Cleanup created directory if build fails #4

Closed tsloughter closed 3 years ago

tsloughter commented 3 years ago

A directory is created before configure is called so it can be passed as the argument to --prefix. This directory should be removed if the build fails and it is empty -- to prevent against deleting deleting an old working install that was being overridden.

lrascao commented 3 years ago

14 now aborts the pipeline if the build step fails, this ensures that a previously working install dir is not clobbered, so maybe we can close this one when PR is closed?

tsloughter commented 3 years ago

Looks good, yup.