search

tsloughter / erlup

Erlang toolchain installer
14 stars 2 forks source link

Feature/generic improvements #6

Closed lrascao closed 4 years ago

lrascao commented 4 years ago

This first PR is a sort of getting acquainted with the project and first getting it to work on my regular use-case. Mostly cosmetic except 6b1212c and 0825fe8 which were actually stopping from successfully building. Other cosmetic changes are open to discussion as personal tastes might vary ofc.

lrascao commented 4 years ago

here's a screenshot of a sample run: https://imgur.com/a/zNDeeUM

tsloughter commented 4 years ago

Looks great. I just wanted to verify, did you test with a user options like in the doc, user_configure_options: ["--without-wx", "--without-odbc", "CFLAGS=-g -O2 -march=native"]? I'm just concerned that the CFLAGS without quoting -g -O2 -march=native might not work.

lrascao commented 4 years ago

Looks great. I just wanted to verify, did you test with a user options like in the doc, user_configure_options: ["--without-wx", "--without-odbc", "CFLAGS=-g -O2 -march=native"]? I'm just concerned that the CFLAGS without quoting -g -O2 -march=native might not work.

i'll double check it

tsloughter commented 4 years ago

Oh, looks like it must work, your screenshot shows it using the CFLAGS arg.

lrascao commented 4 years ago

actually without the quotes it won't work

this works: default_configure_options=--without-wx --without-observer --without-odbc --without-debugger --without-et --enable-builtin-zlib --without-javac CFLAGS="-g -O2 -march=native"

without the quotes it doesn't: default_configure_options=--without-wx --without-observer --without-odbc --without-debugger --without-et --enable-builtin-zlib --without-javac CFLAGS=-g -O2 -march=native

but you need the quotes right? how will configure know what CFLAGS is?

tsloughter commented 4 years ago

@lrascao oh, not what I meant. I should have linked to the spot in the code, one sec :)