search

tsloughter / grpcbox

Erlang grpc on chatterbox
Apache License 2.0
139 stars 62 forks source link

Update grpcbox for chatterbox performance work #102

Closed Vagabond closed 1 year ago

Vagabond commented 1 year ago

Depends on tsloughter/chatterbox#22

tsloughter commented 1 year ago

I think the github actions Ci needs to be updated to ubuntu 20.04 or it won't run.

tsloughter commented 1 year ago

On 25 I get 2 failures because of:

{handshake_failure,
                                                          "TLS server: In state hello at ssl_handshake.erl:2109 generated SERVER ALERT: Fatal - Handshake Failure\n unacceptable_rsa_key"}}}
Vagabond commented 1 year ago

On 25 I get 2 failures because of:

{handshake_failure,
                                                          "TLS server: In state hello at ssl_handshake.erl:2109 generated SERVER ALERT: Fatal - Handshake Failure\n unacceptable_rsa_key"}}}

I'm pretty sure this is some pre-existing bitrot?

Vagabond commented 1 year ago

I thnk the previous CI job needs to be cancelled so it can retry with the new workflow file

tsloughter commented 1 year ago

Yea, it is bitrot. If you have any ideas though let me know :). I've been banging my head against chatterbox on otp-25/26.

Tests are going to fail on 23 so need to drop that.

Vagabond commented 1 year ago

I assume the bundled certificates have become obsolete somehow (I decoded them and they're still chronologically valid) but maybe RSA1024 is no longer allowed?

tsloughter commented 1 year ago

Ah yup, I thought I tried adding that back to allowed and it still failed so thought it wasn't the issue. But generating new keys worked.

Vagabond commented 1 year ago

Ok, I will rebase once you have new keys merged.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.24 :warning:

Comparison is base (855947e) 39.75% compared to head (2ef767c) 39.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== - Coverage 39.75% 39.51% -0.24% ========================================== Files 28 28 Lines 2118 2118 ========================================== - Hits 842 837 -5 - Misses 1276 1281 +5 ``` | [Impacted Files](https://app.codecov.io/gh/tsloughter/grpcbox/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter) | Coverage Δ | | |---|---|---| | [src/grpcbox\_client\_stream.erl](https://app.codecov.io/gh/tsloughter/grpcbox/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter#diff-c3JjL2dycGNib3hfY2xpZW50X3N0cmVhbS5lcmw=) | `68.91% <ø> (-0.42%)` | :arrow_down: | | [src/grpcbox\_subchannel.erl](https://app.codecov.io/gh/tsloughter/grpcbox/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter#diff-c3JjL2dycGNib3hfc3ViY2hhbm5lbC5lcmw=) | `62.22% <40.00%> (-10.51%)` | :arrow_down: | | [src/grpcbox\_stream.erl](https://app.codecov.io/gh/tsloughter/grpcbox/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter#diff-c3JjL2dycGNib3hfc3RyZWFtLmVybA==) | `64.61% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.