search

tsloughter / grpcbox

Erlang grpc on chatterbox
Apache License 2.0
139 stars 62 forks source link

Include paths are agnostic about root dir name #108

Closed camelpunch closed 12 months ago

camelpunch commented 1 year ago

Remove grpcbox/ prefix in include paths. This fixes packaging in nix, which uses a custom directory name to store the source code of hex packages.

See:

https://github.com/ydlr/mix2nix/pull/18#issuecomment-1708998005
https://github.com/NixOS/nixpkgs/blob/f3bbbcd40712205f37cc1060d8e5dfa3639f2d70/pkgs/development/beam-modules/fetch-hex.nix#L10

camelpunch commented 12 months ago

I've just realised that these files are generated with gpb. Would this sort of change need to be made to that project instead?

camelpunch commented 12 months ago

A workaround has been added to mix2nix, which should solve the 80% case for nix users, so I'll close this.

tsloughter commented 12 months ago

Good to hear :+1: