Closed psalin closed 1 year ago
Base: 39.02% // Head: 39.02% // No change to project coverage :thumbsup:
Coverage data is based on head (
549b907
) compared to base (8cad52b
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Did you forget to include some part of this patch? I only see a sleep added and not retries?
Well it only needs a couple of ms so 100ms sleep is more than enough for it to not fail. With so short times the original retry solution was overkill and I removed it.
The client_stream_garbage_collect_streams test occasionally fails because sometimes the check for collected streams is run before the streams have been finished. To stabilize the test, allow some retries to ensure the stream has enough time to be collected.