tsloughter / grpcbox

Erlang grpc on chatterbox
Apache License 2.0
138 stars 61 forks source link

Stabilize garbage collection tests #92

Closed psalin closed 1 year ago

psalin commented 2 years ago

The client_stream_garbage_collect_streams test occasionally fails because sometimes the check for collected streams is run before the streams have been finished. To stabilize the test, allow some retries to ensure the stream has enough time to be collected.

codecov[bot] commented 2 years ago

Codecov Report

Base: 39.02% // Head: 39.02% // No change to project coverage :thumbsup:

Coverage data is based on head (549b907) compared to base (8cad52b). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ======================================= Coverage 39.02% 39.02% ======================================= Files 28 28 Lines 2091 2091 ======================================= Hits 816 816 Misses 1275 1275 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Sloughter)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tsloughter commented 1 year ago

Did you forget to include some part of this patch? I only see a sleep added and not retries?

psalin commented 1 year ago

Well it only needs a couple of ms so 100ms sleep is more than enough for it to not fail. With so short times the original retry solution was overkill and I removed it.