tsloughter / grpcbox

Erlang grpc on chatterbox
Apache License 2.0
139 stars 62 forks source link

Add and remove dynamic endpoints #97

Open sevenhe1205 opened 1 year ago

sevenhe1205 commented 1 year ago

Fix functions parametes

Add and remove dynamic endpoints

Add hash and direct pick strategies

tsloughter commented 1 year ago

Thanks! Sorry I didn't get around to reviewing until now. Curious if you are using this add/remove endpoints feature in production?

sevenhe1205 commented 1 year ago

yes, Service discovery requires grpcbox to have the ability to dynamic and drop endpoints, which we are ready to use in production

tsloughter commented 1 year ago

@sevenhe1205 can you rebase these changes?

I'm going to make a new grpcbox release but then would like to get your changes merged in and another release made.

heshaoqiong1205 commented 12 months ago

@sevenhe1205 can you rebase these changes?

I'm going to make a new grpcbox release but then would like to get your changes merged in and another release made.

I lost my previous account, and this is a new one. I will rebase to the latest main branch. We discovered a new issue: when using the hash strategy, grpc_pool may cause the program to crash when adding and deleting workers. Therefore, we don't use the hash strategy in actual applications. Instead, we use the direct pick strategies.