tsmock / sidewalks

GNU General Public License v2.0
1 stars 0 forks source link

Not adding crossing nodes in all cases #1

Open watmildon opened 4 months ago

watmildon commented 4 months ago

I had an area where the sidewalks were already in place but the crossing did not exist. I entered sidewalk mode and clicked the nodes in order 1,2,3,4. I has missed making crossing nodes for the north/south roadway.

image

tsmock commented 4 months ago

As a stupid question, should the barrier=kerb nodes be in the middle of the sidewalk?

From https://wiki.openstreetmap.org/wiki/Tag:barrier=kerb,

Please do not add a barrier=kerb on a node joining the footways near the crossing (e.g. sidewalk footway joining with footway crossing the road). That would implicate that such kerbs block not only crossing the road, but also just using the sidewalk (i.e. without intending to cross the road), which is almost never the case - and which has a big implication for several classes of users (most notably, wheelchair users).

Anyway, it is still something I should look into, but having a single footway connected to the kerb works. image

watmildon commented 4 months ago

Ah interesting. In that case, maybe it shouldn't add the kerbs at any of the four nodes in the original drawing? Maybe just the crossings? Hmmm.

I drew them like that as it's the most common way around here but I definitely see how the short stub makes the specific routing case better.

watmildon commented 4 months ago

I am on the latest plugin and I've hit this case where the crossing node (and starting kerb) are not added. The first way drawn works as expected. Clicks 2,3,4 don't yield the correct tagging on the node or crossing portion of the way.

Reversing the clicks of 2,3,4 to be 4,3,2 has the expected behavior.

image

watmildon commented 4 months ago

Hmmm. I am having trouble reproducing the case above. I will be more diligent about saving off a layer that exhibits this case.

tsmock commented 4 months ago

That would be appreciated. It might be some combination of tags that causes the problem.