search

tsoding / Noq

Simple expression transformer that is not Coq.
MIT License
253 stars 24 forks source link

Changing termion for crossterm #24

Open SunP04 opened 1 year ago

SunP04 commented 1 year ago

As of 09/10/2023, Termion has no support for Windows. As this looks like a project that shouldn't be attached to just Linux, I propose the use of Crossterm(Termion alternative) for the crossplatform.

By changing only changing that, the code would be accessible in any platform.

rexim commented 1 year ago

I personally think we need to get rid of all of these dependencies to fundamentally solve the "rewriting in a new framework every 6 months" sickness of js developers. I'll see what we can do here.

rexim commented 1 year ago

And before you Rust children go "boo-hoo, rewritting whole termion from scratch is hard, boo-hoo" just remember that we don't need the whole termion.

SunP04 commented 1 year ago

Reopening bc I'm dumb and clicked the wrong buttons, sorry.

SunP04 commented 1 year ago

I personally think we need to get rid of all of these dependencies to fundamentally solve the "rewriting in a new framework every 6 months" sickness of js developers. I'll see what we can do here.

I absolutely agree with that, I just think that with termion, you're too locked into the Linux space, while crossterm (or another option, dunno) can give more possibilities.

And before you Rust children go "boo-hoo, rewritting whole termion from scratch is hard, boo-hoo" just remember that we don't need the whole termion.

I also agree with that. Making it optional can mean that you can just use the framework you like more.