search

tsoding / boomer

Zoomer application for Linux
MIT License
477 stars 41 forks source link

Argument parsing is a mess. #131

Open janAkali opened 1 year ago

janAkali commented 1 year ago

I was inspecting your code to fix the "unreachable code" warning.
But honestly, you should just rewrite this part with std/parseopt

asOptionalParam() used once on a code that ALWAYS quits, so this part of template is completely useless:

        if paramVar.isNone:
          i += 1
        else:
          i += 2
rexim commented 1 year ago

Ah yes, my favorite genre of GitHub contributions. Patches through issues 5Head

janAkali commented 1 year ago

Sorry, I've opened a PR.