tsoding / musializer

Music Visualizer
MIT License
921 stars 97 forks source link

Build issue: Make readdir, closedir, opendir static in nob.h #45

Closed OetkenPurveyorOfCode closed 8 months ago

OetkenPurveyorOfCode commented 1 year ago
raylib.lib(rcore.obj) : error LNK2005: opendir already defined in plug.obj
raylib.lib(rcore.obj) : error LNK2005: closedir already defined in plug.obj
raylib.lib(rcore.obj) : error LNK2005: readdir already defined in plug.obj

Both rcore.c and plug.c (via nob.h) export opendir, closedir and readdir. This results in a linker error. I fixed it currently by declaring them static in nob.h.

davehorner commented 11 months ago

thank you. I made a PR. With the static definition changes you suggested I also got a working build! It just fucking works now.