Implement hotreloading for macOS and Windows and other bugfixes

tsoding / musializer

Music Visualizer

MIT License

957 stars 101 forks source link

Implement hotreloading for macOS and Windows and other bugfixes #74

Closed Markos-Th09 closed 9 months ago

Markos-Th09 commented 10 months ago

Implements hot reloading for macOS and windows

Closes #45 Closes #73

rexim commented 9 months ago

Thank you for the PR! Unfortunately I do not accept feature implementations as per CONTRIBUTING.md sorry.

Markos-Th09 commented 9 months ago

I understand. Are you planning to implement hotreloading on other platforms yourself any time soon?

Markos-Th09 commented 9 months ago

I will extract the bug fixes and typo corrections into a new PR without the hotreloading part

Markos-Th09 commented 9 months ago

Why did you deny this PR but allowed #81 to be merged, which is clearly also a feature implementation? Is there something I am not understanding correctly from CONTRIBUTING.md?