search

tsoding / musializer

Music Visualizer
MIT License
953 stars 100 forks source link

Implementation of HOTRELOADING for Windows (MinGW64) #88

Closed TheStef56 closed 9 months ago

rexim commented 9 months ago

https://github.com/tsoding/musializer/blob/50ea93017fe20ea9b464ef8734b12d9f8f661a8b/CONTRIBUTING.md

TheStef56 commented 9 months ago

https://github.com/tsoding/musializer/blob/50ea93017fe20ea9b464ef8734b12d9f8f661a8b/CONTRIBUTING.md

Isn't hotreloading for windows something that you wanted to implement? it was marked as TODO, so I thought it would have been appreciated

ismagilli commented 9 months ago

I think the reason is as follows:

"I only look into SMALL PRs that suggest"

dlfcn.{c,h} in your PR are large in size.