search

tsoding / musializer

Music Visualizer
MIT License
877 stars 92 forks source link

add hotreload support for windows #90

Closed Markos-Th09 closed 6 months ago

Markos-Th09 commented 6 months ago

Adds hotreload support for the niche video game operating system, for both msvc and mingw.

rexim commented 6 months ago

Is it suppose to work in wine as well? I haven't check the native Windows, but it crashes on wine with "Unhandled page fault on read access". It would be kinda cool if it worked in wine too. :(

Markos-Th09 commented 6 months ago

Is it suppose to work in wine as well? I haven't check the native Windows, but it crashes on wine with "Unhandled page fault on read access". It would be kinda cool if it worked in wine too. :(

This is actually my fault, thank for pointing it out. I didn't realize the new resource loading added new plug functions after the bundling. For future reference after this is merged, make sure to add MUSIALIZER_PLUG before those to maintain windows compatibility.

rexim commented 6 months ago

@Markos-Th09 alright, looks good! Thank you!

Markos-Th09 commented 6 months ago

@Markos-Th09 alright, looks good! Thank you!

On a completely unrelated note, why was #74 closed but this is accepted?

Markos-Th09 commented 6 months ago

also I did a bit of a messup check out #98