search

tsoding / ray-tracer

My ongoing effort to learn how to make Ray Tracers
MIT License
15 stars 2 forks source link

Downgrade to C++14 #60

Closed rexim closed 5 years ago

rexim commented 5 years ago

People are having to much trouble building the project.

notzain commented 5 years ago

Is this an issue you want to fix yourself/on stream?

There are some issues that might need more attention, and you should decide yourself what to do (i.e, finding an alternative to C++17-only std::optional).

If you're okay with it, I would like to make an attempt as well.

rexim commented 5 years ago

@notzain Oh yeah, feel free take this issue! Keep in mind that a big change coming from #59. I will finish #59 today or tommorow. I'm not planning to touch the code much after that until the next ray-tracer stream so you have a whole week. :)

rexim commented 5 years ago

@notzain regarding what to do, I'd go with downgrading to C++14 and getting rid of optional completely. We may try to replace it with an alternative but that will require to change the build and CI which is too much of a hassle IMO. But feel free to suggest anything you want. We can always discuss everything in the PR. :)

rexim commented 5 years ago

Resolved by #61