search

tsoding / tsoder

Twitch Bot for Morning Tsoding streams
https://www.twitch.tv/tsoding
MIT License
4 stars 1 forks source link

Bake ACCESS_TOKEN into the docker image #75

Closed rexim closed 7 years ago

rexim commented 7 years ago

Right now to run the application you have to provide the ACCESS_TOKEN for the docker run command like so:

$ docker run -e ACCESS_TOKEN="<access-token>" --rm tsoder

We need to be able provide the ACCESS_TOKEN at the docker build time like so:

$ docker build --build-arg access_token="<access-token>" -t tsoder .
$ docker run --rm tsoder
rexim commented 7 years ago

There is no need for that: https://github.com/tsoding/tsoder/tree/3c73fc94d811cf0016584df9d72e2ed09b0701af#docker

When you create a container with docker create -e ACCESS_TOKE=<access-token> the envar is "baked" into the container. We don't need to bake it on the image level.