search

tsolomko / SWCompression

A Swift framework for working with compression, archives and containers.
MIT License
238 stars 41 forks source link

Warning during compilation: redundant public modifier #7

Closed benjaminmayo closed 4 years ago

benjaminmayo commented 4 years ago

A simple issue with a simple fix. As of a recent Swift release, the compiler now diagnoses when redundant public modifiers exist on a type. This is causing a warning to be raised in SWCompression.

Screenshot 2019-12-12 at 00 52 25

The warning is in file BZip2+BlockSize.swift. The fix would be to remove the public modifier on the extension (line 8). This would make the warning go away. The actual behaviour of the code would be unchanged.

tsolomko commented 4 years ago

I think this issue was more or less fixed in 8d0e6d5567c2349456039862565bfa493bff55e6.

(Sorry for the long response time: it was a busy end of the year for me.)

benjaminmayo commented 4 years ago

Ah yea, it was fixed in that commit. It's just not in a published SPM release.

tsolomko commented 4 years ago

Today's small update to SWCompression (4.5.3) includes the aforementioned fix.