search

tsostarics / contrastable

Contrast Coding Utilities
https://tsostarics.github.io/contrastable/
Other
0 stars 0 forks source link

Change default columns in glimpse_contrasts #17

Closed tsostarics closed 5 months ago

tsostarics commented 11 months ago

Two things here. First, a column is_scaled should be added, which would help differentiate between contr.helmert and reverse_helmert_code. Second, since dropping trends is only really relevant to polynomial contrasts and dropping trends is somewhat rare anyways, I think the default behavior should be to not include the column if it isn't used. That is, if dropped_trends is all NA (which is likely the most common result), then it's a bit of nuisance to have it there.

Proposal: add parameter show_dropped_trends = FALSE and only include the dropped trends column if it's TRUE. Alternatively, if dropped_trends is all NA and show_dropped_trends is FALSE, don't include the column, and if TRUE, include it; but, if there is a contrast with dropped trends, then ignore show_dropped_trends and show the column anyways.

tsostarics commented 5 months ago

Added a minimal = TRUE parameter, which omits some of the additional columns that I'm assuming most people won't fully understand based on personal experience of having to explain what orthogonal and centered means to people. The function should be refactored a little bit to only compute the extra columns when minimal = FALSE, but for now it should be fine.