tsoteen89 / cochlearProject

Website development for Cochlear
1 stars 0 forks source link

In audiology, when user presses "Enter data for new condition setup", clear any previously made tables for results #245

Closed annevu closed 10 years ago

annevu commented 10 years ago

If you set a condition and grab that conditions previously answered results, and try to answer under a new condition, the previous results still show (even though no condition is set yet)

If I am understanding correctly, we only want to see the results answered for that condition specified.

drjed commented 10 years ago

That's correct. Thanks Anne

On Wednesday, October 8, 2014, Anne Lam notifications@github.com wrote:

If you set a condition and grab that conditions previously answered results, and try to answer under a new condition, the previous results still show (even though no condition is set yet)

If I am understanding correctly, we only want to see the results answered for that condition specified.

— Reply to this email directly or view it on GitHub https://github.com/tsoteen89/cochlearProject/issues/245.

tsoteen89 commented 10 years ago

I'm not sure i'm following, from testing, after I select "Enter Data for new condition setup", everything is cleaned. I then select a new condition, unique to the previous I was working on, and the old results do not show back up. Did you pull the most recent changes made? Or am I not understanding the bug..?

tsoteen89 commented 10 years ago

Okay, figured out what you were trying to say. Sorry about that, I didn't think to try to enter test data without first selecting a condition for which the tests could apply. It's fixed now.

annevu commented 10 years ago

Sorry, should've specified. I did it without selecting a condition after I set one, because I was wondering if the table headers showed without any previous results. In my opinion think the tables(the table headers) should only appear if they were some results. What do you think?

tsoteen89 commented 10 years ago

I feel there's arguments for both sides. If we take the table away unless there are previous answers, it would look cleaner. The argument for keeping the table there if there are no answered questions would give the User the comfort of knowing that after they enter new data, they will still have the ability to see anything previously entered. Whatever you think is best Dr. Grisel.

annevu commented 10 years ago

Well after they answer, the table would show up right? But I get what you mean, the user may or may not want to feel that the result would show before they actually answer.

drjed commented 10 years ago

Ok good point. Let's have the table appear after u enter the first set of values

On Wednesday, October 8, 2014, Anne Lam notifications@github.com wrote:

Sorry, should've specified. I did it without selecting a condition after I set one, because I was wondering if the table headers showed without any previous results. In my opinion think the tables(the table headers) should only appear if they were some results. What do you think?

— Reply to this email directly or view it on GitHub https://github.com/tsoteen89/cochlearProject/issues/245#issuecomment-58457103 .