restyling messages-some functionality not yet transferred

[annevu]

to switch back-go to myApp.js and change to this line templateUrl: 'partials/messages.html' from this line templateUrl: 'partials/inbox.html'

phew, that was a lot of work, @James55 may need your help with some issues and/or finding things that i may not have transferred

[James55]

Awesome job! There's a few things I might be able to help with, I'll see if I can get some stuff transferred over.

[annevu]

Yeah like the received, deleted buttons on the side for alerts, notification aren't working. Thinking it's a scoping issue. But I also didn't check everything yet. Just started it.

Thanks James! Code is great though, you had to handle a lot of stuff!

On Dec 15, 2014, at 11:23 PM, James Rowe notifications@github.com wrote:

Awesome job! There's a few things I might be able to help with, I'll see if I can get some stuff transferred over.

— Reply to this email directly or view it on GitHub.

[James55]

Hey, so it looks like those buttons won't work with their content because they're in separate instances of the same controller. We'll have to either rearrange the html so that the buttons are within the same controller as the content, or if you give me until tomorrow, I can try to combine those 3 controllers into 1 like I was wanting to do at the end of summer. I don't mind doing it, but I'll probably be working on it late tonight.

[annevu]

$patientCareTeam = CareTeams::find("CareTeamID='{$receivedNotification['CareTeamID']}'");

this line in the api under getFacilityDeletedNotifications is causing issues i think, there is not a careteamid in the receivedNotification object and im not sure what you're trying to do so i cant change it.

[James55]

Hmm maybe the notifications used to have a careteam ID instead of a PatientID. It looks like I'm just using that block to get the patient name so maybe taking out the two lines that begin $patientCareTeam and changing the $patient line to:

$patient = Patients::findFirst("PatientID='{$receivedNotification['PatientID']}'");

might do the trick. Might not be the best way to do it, so feel free to change it however you want.