Adding new 404 error template

Ahasasjain commented 9 months ago

Details

Adding a new 404 template in the project please assign me this issue under hacktoberFest 2023.

Checklist

- [X] ``new_template/404.html`` ✅ Commit [`719de93`](https://github.com/tsparticles/404-templates/commit/719de93bb390d8634d40247b3c5188d4d6e993a8) - [X] ``new_template/css/404.css`` ✅ Commit [`964d730`](https://github.com/tsparticles/404-templates/commit/964d730d33c0255a1465c4edb516ecadcf909e5d) - [X] ``new_template/js/404.js`` ✅ Commit [`00424f2`](https://github.com/tsparticles/404-templates/commit/00424f288fa9792525de8d4a7c2017340b9baf0a) - [X] ``data/pages.json`` ✅ Commit [`d4b45a2`](https://github.com/tsparticles/404-templates/commit/d4b45a2647d3a505d5b7e212955ad98402ef6a49)

sweep-nightly[bot] commented 9 months ago

Here's the PR! https://github.com/tsparticles/404-templates/pull/106.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-4. You have 1 GPT-4 tickets left for the month and -1 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)

[ ] ↻ Restart Sweep

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/tsparticles/404-templates/blob/5dfc27124d72886a5d502e99155953c80a2bee42/links/404.html#L1-L46

Step 2: ⌨️ Coding

[X] new_template/404.html ✅ Commit 9b4513a

• Copy the content of the existing 404.html file from the "links" directory.
• Change the title tag to "New Template | tsParticles 404".
• Change the body class to "new_template".
• Change the text within the h1 and h2 tags to "Oh no!" and "404 - This is a new template", respectively.
• Change the href attribute of the anchor tag to the homepage of the new template.
• Change the src attribute of the script tag to point to the new JS file: "js/new_template.js".
[X] new_template/css/new_template.css ✅ Commit 4695e53

• Create a new CSS file with basic styles for the new template. This can include styles for the body, h1, h2, and anchor tags, as well as any additional styles needed for the new template.
[X] new_template/js/new_template.js ✅ Commit 2b501c6

• Create a new JS file with basic functionality for the new template. This can include any interactive elements or animations needed for the new template.

Step 3: 🔁 Code Review

Here are my self-reviews of my changes at sweep/add-new-404-template_1.

Here is the 1st review

Hi there, great job on creating the new 404 error template! There's just one small issue that needs to be addressed: In the `new_template/js/new_template.js` file, you've added an event listener to an element with the class "home-button". However, this class is not assigned to any element in the `new_template/404.html` file. To fix this, you can either: - Add the "home-button" class to the appropriate element in the HTML file (likely the anchor tag that links to the homepage), or - Change the class name in the JS file to match the class of the appropriate element in the HTML file. Once this change is made, everything should work as expected. Keep up the good work!

I finished incorporating these changes.

🎉 Latest improvements to Sweep:

Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. ^{Join Our Discord}

sweep-ai[bot] commented 9 months ago

Here's the PR! https://github.com/tsparticles/404-templates/pull/108.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-3.5. You have 1 GPT-4 tickets left for the month and 0 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)

[ ] ↻ Restart Sweep

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/tsparticles/404-templates/blob/5dfc27124d72886a5d502e99155953c80a2bee42/CONTRIBUTING.md#L1-L67 https://github.com/tsparticles/404-templates/blob/5dfc27124d72886a5d502e99155953c80a2bee42/LICENSE#L1-L20

Step 2: ⌨️ Coding

[X] new_template/404.html ✅ Commit 719de93
• Create a new HTML file named 404.html in the new_template directory.
• In this file, write the HTML structure for the 404 error page. This should include a DOCTYPE declaration, a head section with a title and a link to the CSS file, and a body section with the content of the error page.
• Ensure that the HTML is valid and follows the project's coding standards.

Sandbox Execution Logs

trunk fmt `new_template/404.html` 1/2 ✓
 ✔ Formatted new_template/404.html
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures `new_template/404.html` 2/2 ✓
Checked 1 file
✔ No issues

[X] new_template/css/404.css ✅ Commit 964d730
• Create a new CSS file named 404.css in the new_template/css directory.
• In this file, write the CSS rules for the 404 error page. This should include styles for the body, headings, text, links, and any other elements on the page.
• Ensure that the CSS is valid and follows the project's coding standards.

Sandbox Execution Logs

trunk fmt `new_template/css/404.css` 1/2 ✓
Checked 1 file
✔ No issues
trunk check --fix --print-failures `new_template/css/404.css` 2/2 ✓
Checked 1 file
✔ No issues

[X] new_template/js/404.js ✅ Commit 00424f2
• Create a new JavaScript file named 404.js in the new_template/js directory.
• In this file, write the JavaScript code for the 404 error page. This could include functionality for a back button, animations, or other interactive elements.
• Ensure that the JavaScript is valid and follows the project's coding standards.

Sandbox Execution Logs

trunk fmt `new_template/js/404.js` 1/2 ✓
 ✔ Formatted new_template/js/404.js
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures `new_template/js/404.js` 2/2 ✓
Checked 1 file
✔ No issues

[X] data/pages.json ✅ Commit d4b45a2
• Open the pages.json file in the data directory.
• Add a new object to the array in this file. This object should include the name of the new template, the path to the HTML file, and any other necessary information.
• Ensure that the JSON is valid and follows the project's coding standards.

Sandbox Execution Logs

trunk fmt `data/pages.json` 1/4 ✓
 ✔ Formatted data/pages.json
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures `data/pages.json` 2/4 ✓
Checked 1 file
✔ No issues
trunk fmt `data/pages.json` 3/4 ✓
 ✔ Formatted data/pages.json
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures `data/pages.json` 4/4 ✓
Checked 1 file
✔ No issues

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/add-404-template.

.

🎉 Latest improvements to Sweep:

Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. ^{Join Our Discord}

matteobruni commented 9 months ago

There is already an issue for that. Please use that

tsparticles / 404-templates