Added New 404 template Added(Party Theme)

tsparticles / 404-templates

tsParticles Auth Template for Websites

https://tsparticles.github.io/404-templates/

MIT License

154 stars 82 forks source link

Added New 404 template Added(Party Theme) #109

Closed Ahasasjain closed 11 months ago

Ahasasjain commented 11 months ago

Added New 404 Template using tsparticles please review. issue #97

sweep-ai[bot] commented 11 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All docstrings and comments should be up to date.
[ ] Apply: There should be no instances of commented out code.
[ ] Apply: All error logs should use traceback during exceptions.
[ ] Apply: There should be no instances of import pdb; pdb.set_trace() in production code.
[ ] Apply: There should be no debug log or print statements in production code.
[ ] Apply: All CSS files should be linked using the href attribute.

sweep-nightly[bot] commented 11 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All docstrings and comments should be up to date.
[ ] Apply: There should be no instances of commented out code.
[ ] Apply: All error logs should use traceback during exceptions.
[ ] Apply: There should be no instances of import pdb; pdb.set_trace() in production code.
[ ] Apply: There should be no debug log or print statements in production code.
[ ] Apply: All CSS files should be linked using the href attribute.

Ahasasjain commented 11 months ago

added a screenshot and updated package.json please review @matteobruni

matteobruni commented 11 months ago

The Go Home link is not clickable, and this link https://tsparticles.github.io/404-templates/ should be the home link, not Google.

matteobruni commented 11 months ago

Please refer to the issue description again, I've added the Google Analytics Code and build instructions

Ahasasjain commented 11 months ago

Please refer to the issue description again, I've added the Google Analytics Code and build instructions

Do I have to add this code to the 404.html file?

matteobruni commented 11 months ago

Please refer to the issue description again, I've added the Google Analytics Code and build instructions

Do I have to add this code to the 404.html file?

Yes

Ahasasjain commented 11 months ago

I made the button clickable and added the home page link, also added the Google Analytics Code please review.

matteobruni commented 11 months ago

Please run npm install and npm run prettier, there are formatting issues in your files. I can't merge if the Node.js CI build tasks are failing.