tsparticles / 404-templates

tsParticles Auth Template for Websites
https://tsparticles.github.io/404-templates/
MIT License
159 stars 84 forks source link

New 404 Templates #18

Closed matteobruni closed 2 years ago

matteobruni commented 2 years ago

Any new 404 template is welcome.

Only templates using tsParticles for particle animations will be accepted. If it's not using tsParticles, the PR will be closed and marked as invalid. If more than one is invalid, all the invalid PR will be marked as spam.

Requirements for posting a template:

All the Pull Requests require this format. Any wrong Pull Request will be marked as invalid and closed.

If I receive multiple invalid Pull Requests from the same user, I'll mark them as spam.

aswinikalyan30 commented 2 years ago

can I take this up?

matteobruni commented 2 years ago

can I take this up?

Anyone can work on that, it’s not a single user task.

depimomo commented 2 years ago

I have submitted one template, is it okay to submit more?

matteobruni commented 2 years ago

I have submitted one template, is it okay to submit more?

Yeah sure. It's not a problem to push more than one template in a single PR either.

anmolrajsoni15 commented 2 years ago

Sorry for the inconvenience @matteobruni but can I know where was the issue. Please guide me so that I can make a successful PR

matteobruni commented 2 years ago

Any new 404 template is welcome.

Only templates using tsParticles for particle animations will be accepted. If it's not using tsParticles, the PR will be marked as invalid.

Requirements for posting a template:

All the Pull Requests require this format. Any wrong Pull Request will be marked as invalid and closed.

If I receive multiple invalid Pull Requests from the same user, I'll mark them as spam.

These instructions already explains everything. Reading them is not optional.

Using tsParticles is mandatory in all 404 templates commited here. In your PR it wasn't used, as you can see here: https://github.com/anmolrajsoni15/404-templates/blob/49a4c8e0b2042b97ef84636a0d3e1c3b99273766/human/index.html

After that, all the previews uses a png image, you used a gif. It could be a minor issue, but I prefer having a standard to follow.

And lastly, the data/pages.json wasn't updated. That is the file responsible for showing the template in the index page.

anmolrajsoni15 commented 2 years ago

I am very sorry for that @matteobruni. Please give me a chance by assigning the issue to work on it again . This time I will make sure that all the requirements are fulfilled. Thank You

matteobruni commented 2 years ago

I am very sorry for that @matteobruni. Please give me a chance by assigning the issue to work on it again . This time I will make sure that all the requirements are fulfilled. Thank You

As I said in the other task, assigning tasks is not mandatory for PR. You can submit one anyway. I prefer to keep this task without assignments. The assignments are limited to 10 users, and everyone can submit a template.

sumitbaroniya commented 2 years ago

Please assign me this issue. I would like to contribute in it.

matteobruni commented 2 years ago

Please assign me this issue. I would like to contribute in it.

As said in previous messages, I prefer to not assign the issue. It's an open issue for everyone, so I keep it unassigned. It's not important for the Hacktoberfest

anmolrajsoni15 commented 2 years ago

Hello @matteobruni. I have again tried to make a new page template. But this time before generating PR , , I would like you to review this image. And if it is ok then can I generate the PR ? burning

matteobruni commented 2 years ago

Looks good, there’s a fire 404 but it’s very different

anmolrajsoni15 commented 2 years ago

Ok then I have generated the PR. Please accept it @matteobruni