tsparticles / angular

Angular tsParticles official component
MIT License
31 stars 5 forks source link

Should clean the fireworks when ngOnDestroy #90

Closed Eric-Guo closed 3 months ago

Eric-Guo commented 5 months ago

I really want to avoid any but the upstream code not export FireworksInstance

/**
 * @param idOrOptions - the id used for displaying the animation, or the animation configuration if an id is not necessary
 * @param sourceOptions - the animation configuration if an id is provided
 * @returns the loaded instance
 */
export async function fireworks(
    idOrOptions: string | RecursivePartial<IFireworkOptions>,
    sourceOptions?: RecursivePartial<IFireworkOptions>,
): Promise<FireworksInstance | undefined> {
sweep-nightly[bot] commented 5 months ago

Apply Sweep Rules to your PR?

sweep-ai[bot] commented 5 months ago

Apply Sweep Rules to your PR?

This is an automated message generated by Sweep AI.

Eric-Guo commented 4 months ago

FireworksInstance exported in new version and I using it now.

matteobruni commented 3 months ago

The build is failing, can you please fix it? I cannot merge until it fails

Eric-Guo commented 3 months ago

@matteobruni done and really appreciate your work!

matteobruni commented 3 months ago

Still failing

Eric-Guo commented 3 months ago

Interesting, FireworksInstance exported in already published package, any idea why this error happen?

matteobruni commented 3 months ago

I've checked the files of this PR, you are changing only the component, but the dependencies must be updated as well, since that export came in a newer version of @tsparticles/fireworks.

Please build the project locally before submitting commits.

matteobruni commented 3 months ago

Still failing, please build the project locally before submitting other commits.

pnpm install
pnpm run build

in the root folder.

Eric-Guo commented 3 months ago

Should work, thank you for your patience

matteobruni commented 3 months ago

Everything is fine now, thanks!