tspivey / yugioh-game

Text-based Yu-Gi-Oh MUD
https://allinaccess.com/game/
MIT License
32 stars 23 forks source link

Decreased disconnect timer #279

Open JessicaTegner opened 6 months ago

JessicaTegner commented 6 months ago

Players have indicated that 10 minutes is a long time to wait after a player disconnects from a duel to wait. This pr lowers that time down to 5 minutes.

The rationale:

Timtam commented 6 months ago

My reason for making it ten minutes back in the day was that in countries with bad internet (like in Germany in some places) Internet can randomly drop out and require you to either reboot your router and/or your PC, which can take longer than five minutes. I personally would rather prefer a solution that still keeps the ten minutes, because if you lower it to five people who want to come back but cannot because of, dunno, BSOD or something don't have a chance to take longer than five minutes. I'd rather see a change to the giveup command or some other command that allows the opponent to just cancel the duel without a win/loss count while the other player is currently disconnected. That'd allow for even faster resets than 5 minutes while friends who know that their opponent will come back soon can still opt to wait for their return. @tspivey oppinions?

JessicaTegner commented 6 months ago

I personally don't have an opinion either way. I have just mostly seen people that use it to avoid losing a duel, which rightfully so leaves the winning party frustrated because they were 1 or 2 commands away from winning. Those that legitimately lose connection, usually come back within the minute. I don't think modifying the giveup command to cancel the duel would be a good solution either, because the reason for this decrease was exactly so people that just disconnect to avoid losing, would still lose, without needing for the winning party to sit for 10 minutes waiting for the win. Well unless we modify the command to give the still connected player the win 8if they fx have been sitting for 5 minutes waiting, a message would pop up, telling them that they can type giveup now, and they'll still get the win).

Again, main purpose of this, was to combat rage quitters :) but looking forward to more opinions