search

tspurway / hustle

A column oriented, embarrassingly distributed relational event database.
Other
240 stars 36 forks source link

Fix the order-by stage for binary aggregations #65

Closed ncloudioj closed 6 years ago

ncloudioj commented 6 years ago

This patch removes the last roadblock for landing the Hyperloglog feature in Hustle. The introduction of binary type and its aggregation functions (like h_cardinality(hll)) requires some changes in the Hustle pipeline work.

All unit/integration tests passed. Some hll specific integration tests still missing, will fix that in a follow up patch.

@tspurway r?

tspurway commented 6 years ago

This looks great. Could we add a quick integration test? The fixtures already have a 'token' field that would be perfect for cardinality testing

ncloudioj commented 6 years ago

@tspurway Alright, added various integration tests for h_cardinality.

r?