search

tsriram / twitter-web-night-mode

Chrome / Firefox extension for twitter's night mode
https://tsriram.in/2017/09/24/retiring-twitter-web-night-mode-extension/
MIT License
49 stars 15 forks source link

background colour becomes white after window resize #27

Closed toxzykplayer closed 7 years ago

toxzykplayer commented 8 years ago

I'm using Chrome. I noticed the issue when I had twitter open on my other screen which is smaller than my main screen. The background will only be dark when the browser window is large enough to display the "who to follow" module on the right side, else it will be white.'

dark light

vbop9834 commented 8 years ago

^ Pardon the noise. Was cleaning up a commit :smile:

tsriram commented 8 years ago

No problem @JeremyBellows. Will publish an update to Chrome store with this fix soon. Thanks again!

vbop9834 commented 8 years ago

:+1:

I forgot to remove three-col from the logged-out selector.

tsriram commented 8 years ago

@JeremyBellows I'll push it in. Thanks!

jtanigawa commented 7 years ago

I have this issue on Firefox as well

tsriram commented 7 years ago

@jtanigawa yup, haven't published the fix to Firefox web store yet as the validation for it was failing with some error in manifest file. Will do it in a couple of days.

nickkaczmarek commented 7 years ago

@tsriram I'm assuming we can close this now?

tsriram commented 7 years ago

@Nickkaczmarek yeah, closing it now. Feel free to do so :)